Description
After #85, monorepo detection in validate and edit-package-json commands does not recognize pnpm-workspace.yaml. This causes:
-
commands/validate.ts: isInsideMonorepo() only walks up checking package.json workspaces fields — pnpm monorepos using pnpm-workspace.yaml (without a workspaces field in package.json) are missed, producing false !skills/_artifacts packaging warnings.
-
setup.ts runEditPackageJson(): Has the same blind spot in its inline monorepo detection IIFE — it incorrectly adds !skills/_artifacts to the files array for pnpm monorepo packages.
Expected Behavior
Both commands should detect monorepos via findWorkspaceRoot() → readWorkspacePatterns(), which already handles pnpm-workspace.yaml, package.json workspaces, and other formats.
Reproduction
- Create a pnpm monorepo with
pnpm-workspace.yaml (no workspaces field in root package.json)
- Add skills to a workspace package
- Run
intent validate packages/<pkg>/skills — observe false !skills/_artifacts warning
- Run
intent edit-package-json from a workspace package — observe !skills/_artifacts incorrectly added to files
Description
After #85, monorepo detection in
validateandedit-package-jsoncommands does not recognizepnpm-workspace.yaml. This causes:commands/validate.ts:isInsideMonorepo()only walks up checkingpackage.jsonworkspaces fields — pnpm monorepos usingpnpm-workspace.yaml(without aworkspacesfield in package.json) are missed, producing false!skills/_artifactspackaging warnings.setup.tsrunEditPackageJson(): Has the same blind spot in its inline monorepo detection IIFE — it incorrectly adds!skills/_artifactsto thefilesarray for pnpm monorepo packages.Expected Behavior
Both commands should detect monorepos via
findWorkspaceRoot()→readWorkspacePatterns(), which already handlespnpm-workspace.yaml,package.jsonworkspaces, and other formats.Reproduction
pnpm-workspace.yaml(noworkspacesfield in rootpackage.json)intent validate packages/<pkg>/skills— observe false!skills/_artifactswarningintent edit-package-jsonfrom a workspace package — observe!skills/_artifactsincorrectly added tofiles