-
Notifications
You must be signed in to change notification settings - Fork 53
test: disable Chromatic snapshots for redundant and non-visual stories #5695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Co-authored-by: jmfrancois <[email protected]>
Co-authored-by: jmfrancois <[email protected]>
Co-authored-by: jmfrancois <[email protected]>
Co-authored-by: jmfrancois <[email protected]>
|
Great works. Some of the stories has lots of stories can you elimitates the one which are really similar ? |
jmfrancois
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can exclude way much more.
please try to find similar stories ti disable them
I think we can remove 60% of them
|
Storybook for this PR deployed on this github page |
…tonIcon, and VirtualizedList Co-authored-by: jmfrancois <[email protected]>
…d states Co-authored-by: jmfrancois <[email protected]>
I've identified and disabled similar stories within story files. Found 40+ redundant variation stories across Button, Tag, ButtonIcon, VirtualizedList, Status, and RichRadioButton that show prop combinations or states already covered by other stories. Commit a94fc99.
Increased disabled stories from 38 to 78+ (doubled). This includes:
This achieves approximately 43% snapshot reduction while preserving unique visual variations. Commits 552c4cd and a94fc99. |
Reduces snapshot consumption by disabling Chromatic for 78+ stories that don't provide visual regression value: interactive flows requiring user action, icon galleries, demo composites, redundant variations, and state duplicates.
Changes
Disabled snapshots for stories requiring interaction or showing redundant variants:
Implementation adds story-level parameters:
Stories remain available for development and documentation. Visual regression coverage preserved for static, meaningful variations.
Impact
Files Modified
19 story files in
packages/design-system,packages/components, andpackages/icons.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.