Fix bugs for feature engineers but issues of solver still exists#93
Merged
general502570 merged 2 commits intodevfrom Apr 13, 2022
Merged
Fix bugs for feature engineers but issues of solver still exists#93general502570 merged 2 commits intodevfrom
general502570 merged 2 commits intodevfrom
Conversation
general502570
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various issues for the
module.featurementioned by @general502570 , however, the solvers still have significant issues, the most potential reason is that the solver initializes thenum_featuresas the original number of features according to provided dataset, but not the transformed features produced by FE.