Merged
Conversation
# Conflicts: # full-ifrs17-template/Files/Dimensions.csv # full-ifrs17-template/Import/CloseImportTemplate.ipynb # full-ifrs17-template/Test/ReportVariablesTestBase.ipynb # ifrs17/Constants/Enums.ipynb # ifrs17/DataModel/DataStructure.ipynb # ifrs17/Export/ExportConfiguration.ipynb # ifrs17/Import/ImportScopeCalculation.ipynb # ifrs17/OverviewCalculationEngine.ipynb # ifrs17/Report/ReportScopes.ipynb
|
BigPicture.PNG --> extension should be .png (small) -- check if there are other cases |
dtrzesniak
approved these changes
Nov 22, 2022
dtrzesniak
pushed a commit
that referenced
this pull request
Nov 22, 2022
* Input Data * Inputs * remove all the AA OA stuff from CSM and PL * Adding WO in FP * Adding BOP N to the delta in LRC/LIC reports * signs * flipping WO sign in FP * Adding Over example * adjust examples * docu * last example * Last corrections * Update ref BM * Some changes to BM generation * Adding RI * OverviewCalculationEngine * Correct APA * More test data * signs of Ri * Bm sorting * RV bm * improvements * little improvements * downloading - metadata and indent * more on readme + clean up * implement pr feedbacks * remove Full from path and project name * rename project directory * main readme * typos * test cdn pic * Update README.md * readme - pic links * Full * remove not necessary pics + update 2 links * links * links * link * cash flow convention * ifrs17 workd convention * AoC * take out slices and correct suggestion * read me + remove Cf complex * PV Base * pv add test * add a title to tests * Init Ref Data * pr comment * locked in rates - end of inception year * template youtube video * fix * some more * AoC step in pv * improve OverviewCalculationEngine * comments * comment Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
dtrzesniak
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Input Data * Inputs * remove all the AA OA stuff from CSM and PL * Adding WO in FP * Adding BOP N to the delta in LRC/LIC reports * signs * flipping WO sign in FP * Adding Over example * adjust examples * docu * last example * Last corrections * Update ref BM * Some changes to BM generation * Adding RI * OverviewCalculationEngine * Correct APA * More test data * signs of Ri * Bm sorting * RV bm * improvements * little improvements * downloading - metadata and indent * more on readme + clean up * implement pr feedbacks * remove Full from path and project name * rename project directory * main readme * typos * test cdn pic * Update README.md * readme - pic links * Full * remove not necessary pics + update 2 links * links * links * link * cash flow convention * ifrs17 workd convention * AoC * take out slices and correct suggestion * read me + remove Cf complex * PV Base * pv add test * add a title to tests * Init Ref Data * pr comment * locked in rates - end of inception year * template youtube video * fix * some more * AoC step in pv * improve OverviewCalculationEngine * comments * comment Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
dtrzesniak
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Input Data * Inputs * remove all the AA OA stuff from CSM and PL * Adding WO in FP * Adding BOP N to the delta in LRC/LIC reports * signs * flipping WO sign in FP * Adding Over example * adjust examples * docu * last example * Last corrections * Update ref BM * Some changes to BM generation * Adding RI * OverviewCalculationEngine * Correct APA * More test data * signs of Ri * Bm sorting * RV bm * improvements * little improvements * downloading - metadata and indent * more on readme + clean up * implement pr feedbacks * remove Full from path and project name * rename project directory * main readme * typos * test cdn pic * Update README.md * readme - pic links * Full * remove not necessary pics + update 2 links * links * links * link * cash flow convention * ifrs17 workd convention * AoC * take out slices and correct suggestion * read me + remove Cf complex * PV Base * pv add test * add a title to tests * Init Ref Data * pr comment * locked in rates - end of inception year * template youtube video * fix * some more * AoC step in pv * improve OverviewCalculationEngine * comments * comment Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
dtrzesniak
pushed a commit
that referenced
this pull request
Nov 29, 2022
* Input Data * Inputs * remove all the AA OA stuff from CSM and PL * Adding WO in FP * Adding BOP N to the delta in LRC/LIC reports * signs * flipping WO sign in FP * Adding Over example * adjust examples * docu * last example * Last corrections * Update ref BM * Some changes to BM generation * Adding RI * OverviewCalculationEngine * Correct APA * More test data * signs of Ri * Bm sorting * RV bm * improvements * little improvements * downloading - metadata and indent * more on readme + clean up * implement pr feedbacks * remove Full from path and project name * rename project directory * main readme * typos * test cdn pic * Update README.md * readme - pic links * Full * remove not necessary pics + update 2 links * links * links * link * cash flow convention * ifrs17 workd convention * AoC * take out slices and correct suggestion * read me + remove Cf complex * PV Base * pv add test * add a title to tests * Init Ref Data * pr comment * locked in rates - end of inception year * template youtube video * fix * some more * AoC step in pv * improve OverviewCalculationEngine * comments * comment Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final adjustments:
-Readme
-review feedbacks
-recording