Merged
Conversation
Contributor
Author
|
There are a few problems with Reporting that needs to be addressed. Reason is: the current deploy also incorporates breaking changes for Reporting API. FYI: @sbusato @dcolleoni @dtrzesniak |
Contributor
Author
|
While working on this PR I found out a nasty bug in Activities nuget package. It doesn't behave properly when imported from another notebook. Super odd. Pls refer to the bug 25430 in the dev board. Dev team is alerted and couldn't figure out. Once we get a fix (necessarily before the deploy on prod) I will run the tests from this PR once more. FYI: @sbusato @dcolleoni @dtrzesniak |
dcolleoni
approved these changes
Oct 24, 2022
full-ifrs17-template/Test/SpecificationsFinancialPerformance.ipynb
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Issues encountered with Reports and Activities nuget package have been fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3