Skip to content

Extend Parsed Variables #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkukuljan merged 8 commits into from
Jul 17, 2023
Merged

Extend Parsed Variables #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4083db5
First proposition
tkukuljan Jul 11, 2023
58dbd13
Reverting the change
tkukuljan Jul 11, 2023
3828213
Davides feedback
tkukuljan Jul 12, 2023
0c6d208
Feedback
tkukuljan Jul 13, 2023
2d4c825
Refactoring activity
tkukuljan Jul 13, 2023
c4b5524
Feedback
tkukuljan Jul 14, 2023
70cf530
Merge remote-tracking branch 'origin/develop' into coverageUnitsNorma…
tkukuljan Jul 17, 2023
642fa26
Merge details
tkukuljan Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ifrs17/Import/Importers.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,6 +1458,7 @@
"\n }, ImportFormats.Cashflow",
"\n ).WithTarget(workspace).ExecuteAsync();",
"\n ",
"\n await workspace.ExtendParsedVariables(parsingStorage.HierarchyCache);",
"\n await workspace.ValidateForMandatoryAocSteps(dataSet, parsingStorage.MandatoryAocSteps);",
"\n await workspace.ValidateForDataNodeStateActiveAsync<RawVariable>(parsingStorage.DataNodeDataBySystemName);",
"\n return Activity.Finish().Merge(importLog);",
Expand Down
18 changes: 18 additions & 0 deletions ifrs17/Utils/ImportCalculationMethods.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,24 @@
"execution_count": 0,
"outputs": []
},
{
"cell_type": "markdown",
"source": [
"## Extend Parsed Variables"
],
"metadata": {},
"execution_count": 0,
"outputs": []
},
{
"cell_type": "code",
"source": [
"public static async Task ExtendParsedVariables (this IWorkspace workspace, Systemorph.Vertex.Hierarchies.IHierarchicalDimensionCache hierarchyCache) {}"
],
"metadata": {},
"execution_count": 0,
"outputs": []
},
{
"cell_type": "markdown",
"source": [
Expand Down