Skip to content

ReleasePatterns and EconomicBasisDriver#304

Merged
sbatka merged 43 commits intodevelopfrom
DacAmortFactor
May 26, 2023
Merged

ReleasePatterns and EconomicBasisDriver#304
sbatka merged 43 commits intodevelopfrom
DacAmortFactor

Conversation

@sbatka
Copy link
Copy Markdown
Contributor

@sbatka sbatka commented May 11, 2023

  • add new EstimateType "P" for Patterns to include AmountTypes "CU"

  • move CU from EstimateType to AmountType, including the changes to formulae

  • add 'EconomicBasisDriver' to SingleDataNodeParameters, making it optional

  • add 'ReleasePattern' to SingleDataNodeParameters, making it optional

  • with some documentation and validations

- add 'CashFlowPeriodicity' and 'InterpolationMethod' to cashflow input importer:

  1. check the presence of 'CashFlowPeriodicity' and 'InterpolationMethod' in the cashflow, if available, it will use it. Note this is defined for combination of 'AmountType', 'EstimateType' in the cashflow set.
  2. If any of the 2 parameters is not available, it will check the 'DataNode' level, namely 'SingleDataNodeParameter' and use for all AmountTypes and EstimateTypes in the given DataNode.
  3. In case no information or invalid data is provided, the default values will be used: CashFlowPeriodicity = Monthly and InterpolationMethod = NotApplicable.
  • add "ContractTerm" to GOC (not connected anywhere for now)
  • add basic unit tests for ReleasePattern values

@sbatka sbatka self-assigned this May 17, 2023
@sbatka sbatka linked an issue May 17, 2023 that may be closed by this pull request
@sbatka sbatka changed the title Dac amort factor Patterns and EconomicBasisDriver May 17, 2023
@sbatka sbatka requested a review from dcolleoni May 17, 2023 11:41
@dcolleoni
Copy link
Copy Markdown
Contributor

Because of the changes in the datamodel, we need a new version of the Initial migration. @nnikolopoulos can show you how to produce it. Thanks!

@dcolleoni dcolleoni added this to the v1.3.x milestone May 17, 2023
@dcolleoni dcolleoni added the import related to importing label May 17, 2023
@dcolleoni
Copy link
Copy Markdown
Contributor

Could you add some description in the DataStructure NB for these new properties in the SingleDataNodeParameter?

@sbatka
Copy link
Copy Markdown
Contributor Author

sbatka commented May 25, 2023

I have now added a test on ReleasePattern invalid and Null values.

@sbatka sbatka closed this May 25, 2023
@sbatka sbatka reopened this May 25, 2023
@sbatka sbatka changed the title Patterns and EconomicBasisDriver ReleasePatterns and EconomicBasisDriver May 25, 2023
@sbatka sbatka requested a review from dcolleoni May 25, 2023 08:43
@sbatka sbatka requested a review from dcolleoni May 25, 2023 11:20
@sbatka sbatka merged commit 5f0a4df into develop May 26, 2023
@sbatka sbatka deleted the DacAmortFactor branch May 26, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

import related to importing

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Patterns and EconomicBasis

2 participants