Skip to content

Allow for more Aoc steps in the Combined section#267

Merged
dcolleoni merged 3 commits intodevelopfrom
ExtendCombinedAoc
Apr 17, 2023
Merged

Allow for more Aoc steps in the Combined section#267
dcolleoni merged 3 commits intodevelopfrom
ExtendCombinedAoc

Conversation

@dcolleoni
Copy link
Copy Markdown
Contributor

@dcolleoni dcolleoni commented Apr 11, 2023

This is the first part of the this story.
Here I allow for AU and EV or any other step to be provided with Novelty Combined.
CL,C always needs to be provided and corresponds to the last test.

The second part (separate PR) will deal with the user providing a BOP where NB can't be split from I component (therefore input with Novelty C).

@dcolleoni dcolleoni added the import related to importing label Apr 11, 2023
@dcolleoni dcolleoni added this to the v1.2.x milestone Apr 11, 2023
@dcolleoni dcolleoni self-assigned this Apr 11, 2023
@dcolleoni dcolleoni linked an issue Apr 11, 2023 that may be closed by this pull request
@dcolleoni dcolleoni requested review from dtrzesniak and sbatka April 14, 2023 16:02
@dcolleoni dcolleoni merged commit 5a0754d into develop Apr 17, 2023
@dcolleoni dcolleoni deleted the ExtendCombinedAoc branch April 17, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

import related to importing

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Generalize AocStep structure scopes to enhance Combined chain Part1

2 participants