Merged
Conversation
added 3 commits
January 27, 2023 09:13
dtrzesniak
reviewed
Jan 31, 2023
added 2 commits
February 7, 2023 12:07
dtrzesniak
approved these changes
Feb 8, 2023
dcolleoni
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the following visualizations in the Reports:
Furthermore, this PR introduces a new scope called Data which caches the DataCube for each
ReportingPeriod, ReportingNode, Scenario, CurrencyType, ReportType, Filter
while before the DataCube was always recalculated when one of these parameters was changed, now it will be cached so as much computational effort can be spared. This idea came after the introduction of the scenario deltas calculation which happens after the datacube is composed.