Skip to content

IfrsVariable Projections#197

Merged
AlekseiNekrasov merged 108 commits intodevelopfrom
ProjectionsIdeas_Aleksei
Apr 14, 2023
Merged

IfrsVariable Projections#197
AlekseiNekrasov merged 108 commits intodevelopfrom
ProjectionsIdeas_Aleksei

Conversation

@AlekseiNekrasov
Copy link
Copy Markdown
Contributor

@AlekseiNekrasov AlekseiNekrasov commented Jan 25, 2023

No description provided.

@dcolleoni dcolleoni mentioned this pull request Jan 26, 2023
@dcolleoni
Copy link
Copy Markdown
Contributor

Comment form #176
@dtrzesniak : I was wondering why we did this here, also in V7. The RawVar have double[], the Report Variable have Value and Projection as properties. Isn't there a way we can do that without hardcoding the number of projections?

@dcolleoni dcolleoni added projection related to projection import related to importing labels Jan 26, 2023
@dcolleoni dcolleoni added this to the v1.3.0 milestone Jan 26, 2023
@AlekseiNekrasov AlekseiNekrasov force-pushed the ProjectionsIdeas_Aleksei branch from d5a119b to aaadb51 Compare January 27, 2023 12:26
@AlekseiNekrasov AlekseiNekrasov force-pushed the ProjectionsIdeas_Aleksei branch from ab331fd to d9d75f4 Compare February 1, 2023 15:49
…6 & 2021-12 commented out; remove unnecessary BM_CH_2020_12__BE_Projection.csv, bring in BM_CH_2021_3__BE_Projection.csv with correct Value1; IfrsVariablesTest.nb: enable testing only BM_CH_2021_3__BE_Projection.csv, introduce a new IfrsVariableComparer that compares Value1 -- instead of EqualityComparer, adjust testing
@AlekseiNekrasov AlekseiNekrasov force-pushed the ProjectionsIdeas_Aleksei branch from 54d445a to 222f1d0 Compare February 7, 2023 14:20
@andrey-katz-systemorph andrey-katz-systemorph self-assigned this Apr 3, 2023
@andrey-katz-systemorph andrey-katz-systemorph linked an issue Apr 5, 2023 that may be closed by this pull request
akatz and others added 6 commits April 11, 2023 18:12
@AlekseiNekrasov
Copy link
Copy Markdown
Contributor Author

AlekseiNekrasov commented Apr 14, 2023

@andrey-katz-systemorph Running of the cell that contains the following method throws errors:
image

image

@andrey-katz-systemorph
Copy link
Copy Markdown
Contributor

@andrey-katz-systemorph Running of the cell that contains the following method throws errors: image

image

I have just checked, runs properly for me with all the tests being green,

@AlekseiNekrasov AlekseiNekrasov merged commit da12969 into develop Apr 14, 2023
@AlekseiNekrasov AlekseiNekrasov deleted the ProjectionsIdeas_Aleksei branch April 14, 2023 11:00
@AlekseiNekrasov
Copy link
Copy Markdown
Contributor Author

AlekseiNekrasov commented Apr 14, 2023

@andrey-katz-systemorph Running of the cell that contains the following method throws errors: image

image

It was not caused by that the "ifrs17" project was not imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

import related to importing projection related to projection

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Projection data model - use double[] in IfrsVariable

4 participants