Conversation
added 3 commits
January 16, 2023 09:24
dtrzesniak
approved these changes
Jan 17, 2023
revert all changes
revert: no changes in PV
dtrzesniak
reviewed
Jan 19, 2023
# Conflicts: # ifrs17-template/Export/MapTemplate.ipynb
dcolleoni
approved these changes
Jan 19, 2023
Contributor
|
One observation is that if the import of the file fails the error is captured in the activity log. This means no exception is thrown and the try catch performs then the code in the try section. In this case it stores the activity with a SourceId and the corresponding FileSource even though the activity failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a slightly different API for saving the logs
.WithLogsRecordedInDb(....).ExecuteAsync() instead of ExecuteWithStoreActivityAsync() and changes all the PV and template uses accordingly. Changing the type of SourceId from Guid to Guid? to avoid fake IDs in failed imports.