Migrate from python-ldap to ldap3

[mprahl]

• Turn off logging during tests
• Replace python-ldap code with ldap3
• Simplifies the check_nested_group_membership function so that the membership checking is done in AD and not in Python
• Since ldap3 allows NTLM authentication against AD, this was added as a config option
• Unit tests greatly simplified

This is a big PR, I think it'd be easier for you to review on a per commit basis (I tried to make those neat and concise changes).

[thatarchguy]

Either use .format or .join to format strings.

[mprahl]

Good point, I'll fix this tonight.

[thatarchguy]

Either use .format or .join to format strings.

[mprahl]

Good point, I'll fix this tonight.

[thatarchguy]

How does this create a circular import on json_logger?

[mprahl]

It's because AD relies on json_logger which is defined in utils.py. If I import AD at the top of the file, it tries to import json_logger which is not yet defined.

Is this okay or should we separate the files out somehow?

[thatarchguy]

We may run into this in the future. It may be better to separate the logger out into its own logger.py file.

[thatarchguy]

My oh my I hope this was exported from somewhere!

[mprahl]

Fortunately, yes :)

Here's an example from the docs:

from ldap3 import Server, Connection, ALL_ATTRIBUTES
server = Server('my_real_server')
connection = Connection(server, 'cn=my_real_user,ou=test,o=lab', 'my_real_password', auto_bind=True)
if connection.search('ou=test,o=lab', '(objectclass=*)', attributes=ALL_ATTRIBUTES):
    connection.response_to_file('my_entries.json', raw=True)

[thatarchguy]

Beautiful merge request. I can only really nitpick at one or two small things. The tests are good and the code is good. I really appreciate the hard work you put into that merge.

I think the way we are handling config stuff in the database is getting a bit big. Controllable though, just something we may need to keep an eye on in the future.

[mprahl]

@thatarchguy thoughts on the last commit?

[thatarchguy]

👍