Replace GIF spinner with CSS spinner#177
Merged
thatarchguy merged 1 commit intomasterfrom Nov 2, 2016
Merged
Conversation
thatarchguy
requested changes
Nov 1, 2016
| var spinnerHtml = $('<div/>', {'class': 'spinner'}); | ||
| spinnerHtml.append($('<div/>', {'class': 'bounce1'})); | ||
| spinnerHtml.append($('<div/>', {'class': 'bounce2'})); | ||
| spinnerHtml.append($('<div/>', {'class': 'bounce3'})); |
Member
Author
There was a problem hiding this comment.
You prefer the following?
spinnerHtml.append($('<div/>').addClass('bounce1'));
It's really the same thing except this other way you create the div and then add the class, instead of creating the div with the class.
Member
There was a problem hiding this comment.
Ahh, I was really just trying to simplify this part: spinnerHtml.append($('<div/>',
It just looked odd to me. But then again I'm not really versed in DOM manipulation all that well.
thatarchguy
approved these changes
Nov 2, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new spinner now requires IE10+, but that should be fine considering that lower than IE11 is deprecated:
https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support