Fix duplicate property send in button plugins #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinnejean
reviewed
Jan 30, 2024
| ## License | ||
|
|
||
| Copyright (c) 2022 [SpringRoll](http://github.com/SpringRoll) | ||
| Copyright (c) 2024 [SpringRoll](http://github.com/SpringRoll) |
Contributor
There was a problem hiding this comment.
👀 is this something we need to update in all the SpringRoll plugins?
Contributor
Author
There was a problem hiding this comment.
To be honest I have no idea. Its just something I update whenever I notice it
corinnejean
approved these changes
Jan 31, 2024
jeremymccurdy-redspace
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that some legacy behaviour was hanging around in the Sound and CaptionsToggle plugins where in the
start()method they'd read from localstorage and automatically send the mute states to the application.These values were already being sent during the
sendAllPropertiescall and are considered duplicate.For review this is where the
loadedevent is sent from SpringRoll 2.It is possible the event won't be sent if there's a problem, but that likely speaks to a larger issue in the game and we might not want to keep going regardless. Even with that possibility, slider based plugins in container won't send their values without the
loadedevent so this brings the mutes more inline with that behaviour.