StartScript with Side and AIOptions#516
Merged
gajop merged 4 commits intoSpring-Chobby:masterfrom Oct 10, 2020
Merged
Conversation
gajop
reviewed
Oct 8, 2020
Member
gajop
left a comment
gajop
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks pretty good!
Contributor
Author
|
Turns into PR for AIOptions, with base for future Side selection. Side UI has to be thought separately to make it similar for players and AI. (wrong name for current branch :) ) |
Member
|
looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional step for AI selection with AIOptions window (side selection is also here).
AI side selection works only in singleplayer; maybe there's better place for a function that reads sidedata.lua
AIOptions window is disabled by default and controlled by
WG.Chobby.Configuration.gameConfig.skirmishDefault.AIOptionsEnabledparam