fix: update formatters which were tied to outdated fields #20
Open
rsned wants to merge 4 commits intoSpaceMolt:mainfrom
Open
fix: update formatters which were tied to outdated fields #20rsned wants to merge 4 commits intoSpaceMolt:mainfrom
rsned wants to merge 4 commits intoSpaceMolt:mainfrom
Conversation
- System info: read from r.system wrapper, display rich POI/connection data - POI info: read from r.poi wrapper, show base details and services - Cargo: field renamed from cargo_used to used - Nearby: match r.nearby array, add pirate/NPC sections, player colors - Add hexColor() helper for 24-bit ANSI terminal colors from player data - Remove player ID lines from nearby output for cleaner display Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
get_systemget_cargo |
Author
get_poi=== POI: Main Belt === ID: main_belt Type: asteroid_belt System: sol Description: Rich asteroid field between Mars and Jupiter. Contains rare Sol Alloy deposits. Class: metallic Resources: - |
…, POI resources - Refactor formatters to NamedFormatter with name/hintKeys for drift detection - Log [DRIFT WARNING] when response keys match a formatter's hints but format fails - Extract formatPlayer() helper, shared by get_nearby and get_location - Fix get_poi to show resources from top-level r.resources (moved from r.poi) - Show remaining/max_remaining for resources, color-coded by percent left - Strikethrough depleted resources, show POI class field Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
It now warns when the formatter no longer triggers for a given command as well: [DRIFT WARNING] 'travel' response has keys matching formatter(s) [system_info, poi_info] but none matched. Response keys: [action, online_players, online_players_count, online_players_truncated, poi, poi_id] |
…splay - Add arrival formatter for travel/jump showing destination and online players - Fix drift detection to require all hint keys (not just one) to reduce false positives - Handle missing ship_class in formatPlayer() for travel responses Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add chat_sent formatter showing channel, timestamp, and message - Show item IDs next to names in cargo display - Change cargo size display from "(N each)" to "Size: N" Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big finding: several formatters are broken because the server response structure
changed from what the formatters expect: