function as group.put not working with nested sortables

[nilmerg]

Problem:

A function bound to group.put returns false but the drop is still rendered and accepted for nested sortables. For non-nested sortables this works fine.

JSBin/JSFiddle demonstrating the problem:

https://jsbin.com/mucilolido/edit?html,css,js,output

Environment

Broken Sortable.js Version: 1.8.0
Working Sortable.js Version: 1.8.0-rc1

[nilmerg]

Currently digging into this because it blocks me.

It's due to putSortable now being the Sortable (the nested one) while hovering over it with the item.
With 1.8.0-rc1 it's its immediate parent Sortable hence the condition is false and checkPut is being called. With 1.8.0 it's not.

Currently I have no idea why nor how to solve this. Maybe a side-effect of one the fixes? (Can't tell if, as your commit history is not really helpful in this regard.)

[nilmerg]

Well, as far as I can tell it's indeed a problem with how putSortable is now handled. The only thing I'm really sure of is that with 1.8.0-rc1 putSortable was never set to the Sortable for which my function bound to group.put returned false.

Though, even by putting the block which defines putSortable where it previously has been the issue persists. So I'm either on a totally wrong track or something else is going on here as well. Maybe someone with more knowledge of the code is able to pin-point the issue..

[owen-m1]

@nilmerg Indeed it works in 1.8.0-rc1, but only because bubbling is blocked, which is sub-optimal.

Problem was that target was being set to the li item in the nested sortable, but within the context of the yep sortable, so it thought it was OK to insert after the nested li.

Try master.

Use this link: https://raw.githack.com/SortableJS/Sortable/master/Sortable.js

[nilmerg]

Yes, works like a charm. Thanks a bunch!