update polite ping pong with new protocol#285
Merged
dieriver merged 3 commits intoSoftwareQuTech:release4.0.0-new_sdkfrom Mar 23, 2026
Merged
Conversation
dieriver
reviewed
Mar 23, 2026
| print(f"Alice [{state}]: connection dropped unexpectedly.") | ||
| break | ||
| msg = data.decode("utf-8") | ||
| msg = data.decode().strip() |
Collaborator
There was a problem hiding this comment.
Despite UTF-8 decoding is implicit, I would still make it explicit, for teaching purposes
| rounds_left = NUM_ROUNDS | ||
|
|
||
| # ── Event loop ──────────────────────────────────────────────────────────────── | ||
| async def handle_ready(writer: StreamWriter) -> str: |
Collaborator
There was a problem hiding this comment.
Despite technically possible, I would not define these functions nested; it makes the code of run_alice much longer than needed. Being this said, I would move the functions (and the dispatcher declaration) to the outside scope.
To do this, you might need to declare rounds_left in that scope, and declare it as "global" inside the bodies of the functions that use that var.,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR updates polite ping pong example with new protocol implementation.