Implement discontiguous buffer handling#1109
Merged
JimBobSquarePants merged 66 commits intomasterfrom Feb 21, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
=========================================
+ Coverage 82.04% 82.15% +0.1%
=========================================
Files 680 686 +6
Lines 28562 29048 +486
Branches 3238 3308 +70
=========================================
+ Hits 23434 23864 +430
- Misses 4453 4485 +32
- Partials 675 699 +24
Continue to review full report at Codecov.
|
antonfirsov
changed the title
Member
Author
|
Looks like I managed to fix everything, removed the WIP tag, ready for final review. |
JimBobSquarePants
approved these changes
Feb 21, 2020
Member
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Fantastic work!
All looks good to me, just spotted a possible optimization opportunity in RowOctet<T>
I like that we can implement any enhancements to individual codecs in the future.
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Marked as WIPbecause processors and codecs need adaption, but the core logic is ready to review!MemorySource<T>has been replaced withMemoryGroup<T>, which is a list of uniformly sized buffers (IMemoryOwner<T>andMemory<T>)MemoryGroupExtensionseg..CopyTo()MemoryGroupView<T>is an indirection to expose these memory buffers in a safe way, see docs and comments for more infoAdvancedMemoryExtensionshave been changed to reflect the new memory model,.GetPixelSpan<T>()has been made obsoletebuffer2d.GetSpan<T>()--->buffer2d.GetSingleSpan<T>(), temporarily marked[Obsolete]to guide refactorTODO
We should no longer process
Buffer2Das a single span (except of a few special cases like resize KernelMap). Guidance: go through all[Obsolote]warnings.Resolves #898, Fixes #805