fix: Missing input validation for token scopes#165
Open
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Open
fix: Missing input validation for token scopes#165mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Missing input validation for token scopes
Category: security
Severity: medium
Issue
Token scopes are validated against a predefined list but there's no check for duplicate scopes or case sensitivity handling beyond the initial lowercase conversion. This could lead to inconsistent permission handling.
Fix
The fix adds duplicate scope detection by using a map to track seen scopes. This prevents duplicate scopes from being added to the token while preserving the case-insensitive handling already implemented with strings.ToLower(). The fix is minimal and maintains backward compatibility.
Generated by nyxCore AutoFix