-
Notifications
You must be signed in to change notification settings - Fork 25
Openmemory mcp #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openmemory mcp #69
Changes from all commits
6732501
92c6e17
34f1326
62478ca
4203f58
c8d6f7c
4188634
6cd02fb
c5680be
fb6d4f7
cd14630
3fef05b
2d4370b
c7d0dce
fc89099
160aa6a
2fe095f
cb50a25
a7560b6
6f59aae
a3ccc38
38d8033
7751cc0
88fa639
44635fe
67f72d3
d83c5a0
735aef8
bd9d017
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,6 +2,8 @@ | |||||
| *.wav | ||||||
| **/*.env | ||||||
| !**/.env.template | ||||||
| **/memory_config.yaml | ||||||
| !**/memory_config.yaml.template | ||||||
| example/* | ||||||
| **/node_modules/* | ||||||
| **/ollama-data/* | ||||||
|
|
@@ -58,4 +60,8 @@ extras/speaker-recognition/outputs/* | |||||
| # my backup | ||||||
| backends/advanced/src/_webui_original/* | ||||||
| backends/advanced-backend/data/neo4j_data/* | ||||||
| backends/advanced-backend/data/speaker_model_cache/ | ||||||
| backends/advanced-backend/data/speaker_model_cache/ | ||||||
|
|
||||||
|
Comment on lines
+63
to
+64
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVerify path correctness: “backends/advanced-backend” may be a typo. Most paths in this repo use backends/advanced. Check whether backends/advanced-backend/* actually exists; if not, this ignore entry does nothing and could indicate drift or a rename. Run this to confirm: 🏁 Script executed: #!/bin/bash
fd . -td -a | rg -nP '^backends/(advanced|advanced-backend)\b' -nLength of output: 67 To ensure we’re accurately detecting whether the directory exists, let’s explicitly list and filter the subdirectories under 🏁 Script executed: #!/bin/bash
# List all first-level directories under backends
echo "All backends/* directories:"
find backends -maxdepth 1 -type d
# Strip the leading path and filter for ‘advanced’ or ‘advanced-backend’
echo ""
echo "Filtering for ‘advanced’ or ‘advanced-backend’ exactly:"
find backends -maxdepth 1 -type d | sed 's|.*/||' | grep -E '^advanced(-backend)?$' || echo "→ None found"Length of output: 394 Correct stale .gitignore entry • File: .gitignore, lines 63–64 - backends/advanced-backend/data/speaker_model_cache/
+ backends/advanced/data/speaker_model_cache/This ensures speaker_model_cache remains properly ignored. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| *.bin | ||||||
| *.sqlite3 | ||||||
| *checkpoints | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Repo-wide ignore of memory_config.yaml conflicts with Dockerfile COPY.
Ignoring all memory_config.yaml means it won’t exist in the build context by default. Since backends/advanced/Dockerfile tries to COPY it, builds can fail unless pre-generated. Either:
If you prefer the latter, narrow the ignore rule and allow the advanced backend path through:
But the Dockerfile-side fix is cleaner and avoids committing env-specific configs.
📝 Committable suggestion
🤖 Prompt for AI Agents