This repository was archived by the owner on Nov 26, 2025. It is now read-only.
feat: remove @shopify prefix from flipper plugin name to fix installation issue#95
Merged
ElviraBurchik merged 2 commits intomainfrom Aug 29, 2022
Merged
feat: remove @shopify prefix from flipper plugin name to fix installation issue#95ElviraBurchik merged 2 commits intomainfrom
ElviraBurchik merged 2 commits intomainfrom
Conversation
fortmarek
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@shopify/flipper-plugin-react-native-performance plugin fails to install with an error:
It happens because the package is prefixed with
@shopifyand flipper fails to find it. More details in this issue.Unfortunately, the issue doesn't look to be resolved any time soon, so we decided to rename the plugin to
flipper-plugin-shopify-react-native-performanceto avoid this problem.Description
Fixes issue #83
Test plan
Try to install this archive:
flipper-plugin-shopify-react-native-performance.tgz
Checklist