use the parameter's runtime type to resolve the validator rather than its declared type#47
Merged
mvdgun merged 3 commits intoSharpGrip:masterfrom Dec 11, 2024
Merged
Conversation
…tor instead of its declared type Fixes SharpGrip#46
mvdgun
reviewed
Dec 11, 2024
| { | ||
| var parameterInfo = (parameter as ControllerParameterDescriptor)?.ParameterInfo; | ||
| var parameterType = parameter.ParameterType; | ||
| var parameterType = subject!.GetType(); |
Member
There was a problem hiding this comment.
Do we know for sure that subject is not null if the TryGetValue returns true in this case? Further down there is a null check on subject.
Contributor
Author
There was a problem hiding this comment.
I just pushed another commit to support a potentially nullable subject.
Thank you.
mvdgun
requested changes
Dec 11, 2024
| if (subject != null && parameterType.IsCustomType() && | ||
| !hasAutoValidateNeverAttribute && (hasAutoValidateAlwaysAttribute || HasValidBindingSource(bindingSource)) && | ||
| serviceProvider.GetValidator(parameterType) is IValidator validator) | ||
| serviceProvider.GetValidator(parameterType!) is IValidator validator) |
Member
There was a problem hiding this comment.
@icnocop now you are overriding the nullability over here, I would do:
subject != null && parameterType != null && parameterType.IsCustomType() && etc...
Contributor
Author
There was a problem hiding this comment.
I'm not sure when parameterType would be null when subject is not null.
In any case, I just pushed another commit to support a potentially nullable parameterType, as you recommended.
Thank you.
mvdgun
approved these changes
Dec 11, 2024
Member
|
Merged, thank you! |
mvdgun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46