Removed dependency on IServiceProvider from endpoint and action filter constructors.#26
Closed
mgernand wants to merge 0 commit intoSharpGrip:release/1.4from
mgernand:release/1.4
Closed
Removed dependency on IServiceProvider from endpoint and action filter constructors.#26mgernand wants to merge 0 commit intoSharpGrip:release/1.4from mgernand:release/1.4
mgernand wants to merge 0 commit intoSharpGrip:release/1.4from
mgernand:release/1.4
Conversation
Member
|
Hi @mgernand, I just merged a couple of pull requests and unfortunately your pull request has conflicts now :(. From the looks of it it's shouldn't be very hard to resolve. |
Contributor
Author
|
No problem. I'll take a look tomorrow. 🙂 |
Member
|
Great! Could you also remove |
Contributor
Author
|
@mvdgun The tests of the current release/1.4 branch has errors. So I will wait until those are fixed and will open another PR then. |
Member
|
@mgernand I just fixed the tests in the release/1.4 branch |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service provider is available via the HTTP context.