fix: correct HTML entity encoding and file permission mask#293
Open
Sim-hu wants to merge 1 commit intoSebOuellette:masterfrom
Open
fix: correct HTML entity encoding and file permission mask#293Sim-hu wants to merge 1 commit intoSebOuellette:masterfrom
Sim-hu wants to merge 1 commit intoSebOuellette:masterfrom
Conversation
- Add missing semicolon to '&' entity in parseHTML() - Change process.umask(0) to process.umask(0o022) for safe default permissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small bug fixes: an HTML entity encoding bug and an overly permissive file permission setting.
Changes
1. Fix
parseHTML()entity encodingFile:
js/parseFunctions.jsThe
&character was being replaced with&(missing trailing semicolon), which is not a valid HTML entity. This could cause rendering issues in certain HTML parsers.2. Fix
process.umask(0)security issueFile:
js/app.jsprocess.umask(0)clears all permission restriction bits, meaning any files created by the application are readable, writable, and executable by all users on the system. Changed to the standard default umask0o022, which restricts group/other write permissions while still allowing the application to function normally.Test plan
&characters render correctly in the UI