Open
Conversation
Fixing all the sign conversion, undef, etc warnings in libjson. Signed-off-by: Tyler Erickson <tyler.erickson@seagate.com>
Signed-off-by: Tyler Erickson <tyler.erickson@seagate.com>
Contributor
|
still seeing lots of warnings with all the meson builds. Can you reopen the feature branch, I have some more fixes to add. But the feature branch lock to where I can't push some fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing all the sign conversion, undef, etc warnings in libjson.
There were a lot of warnings coming from this code in modern compilers.
All changes are C++11 compatible and resolve all warnings in GCC 15.2.1
I also added the test suite into meson as something that can be run.
While it runs, meson does not understand the output correctly so running
meson testproduces an incorrect result saying everything passes. The old test code writes it's own HTML style output file which you need to open to check the results.The meson.build was also updated to be more proper meson rather than cheap and quick makefile conversion.
So it sets all compiler flags/options for each built type (release/debug/etc) the way the makefile would, but according to meson's rules/options.
I also upped the warning level to 2 and added in the hardening related options from our other opensea-libraries.
I did not get a chance to try upgrading that, so that should be a feature for the next person 😄