Fix issue with log destroyed error message on mount and extra logs on unmount#856
Open
jfantinhardesty wants to merge 1 commit intomainfrom
Open
Fix issue with log destroyed error message on mount and extra logs on unmount#856jfantinhardesty wants to merge 1 commit intomainfrom
jfantinhardesty wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
This fixes extra errors that were printed on mount success where the logger could be destroyed multiple times and print out a message like:
Now the logger can only be destroyed once. Also removed extra logging in unmount that was printing to stdout.
Checklist
Related Issues