Refactored frontend routing and extended middleware response wrapper#47
Merged
ScriptyChris merged 3 commits intodevelopfrom Nov 14, 2021
Conversation
…n routing contexts (routes, redirections, links, history manipulations); Refactor frontend routing - subpages are now located under '/pages' path and shop related ones under '/shop' path; Add NotFound component, which handles unmatched routes (404 alike);
…tus' and 'data' value according to IEmbracedResponse interface;
…les to use resWrapper function for calls to Express.res method;
ScriptyChris
added
the
maintenance
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially related to #22.
.json(..)method conforms the interface, but also if it's consistent with certain group of HTTP status codes (like 'successful' or 'client error'). Wrapper also has overloads, which let sending just the HTTP status without any data (like in204case)