Skip to content

987 Start print_table() with a line break#989

Merged
mknaranja merged 2 commits intomainfrom
987-print_table-does-not-start-a-new-line
Apr 4, 2024
Merged

987 Start print_table() with a line break#989
mknaranja merged 2 commits intomainfrom
987-print_table-does-not-start-a-new-line

Conversation

@mknaranja
Copy link
Member

@mknaranja mknaranja commented Apr 3, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Start print_table() with a line break

If need be, add additional information and what the reviewer should look out for in particular:

  • nothing

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@mknaranja mknaranja requested a review from reneSchm April 3, 2024 16:06
@mknaranja mknaranja linked an issue Apr 3, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (8ddb863) to head (505bab8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   96.34%   96.32%   -0.02%     
==========================================
  Files         129      129              
  Lines       10056    10056              
==========================================
- Hits         9688     9686       -2     
- Misses        368      370       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please update the python test as well:

Traceback (most recent call last):
  File "/home/runner/work/memilio/memilio/pycode/memilio-simulation/memilio/simulation_test/test_time_series.py", line 61, in test_print_table
    self.assertEqual(
AssertionError: '\nTime a \n2.00 1.00\n3.50 2.00\n' != 'Time a \n2.00 1.00\n3.50 2.00\n'

I don't think it's necessary, but should we mention that the table starts with a newline in the doc comment?

@mknaranja mknaranja merged commit b1b8f37 into main Apr 4, 2024
@mknaranja mknaranja deleted the 987-print_table-does-not-start-a-new-line branch April 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

print_table does not start a new line

2 participants