Skip to content

983 bundle the boost git repo instead of using the targz archiv#985

Merged
dabele merged 40 commits intomainfrom
983-bundle-the-boost-git-repo-instead-of-using-the-targz-archiv
Apr 18, 2024
Merged

983 bundle the boost git repo instead of using the targz archiv#985
dabele merged 40 commits intomainfrom
983-bundle-the-boost-git-repo-instead-of-using-the-targz-archiv

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Apr 3, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • The boost dependency is now also bundled by cloning a git repo instead of using an archive included in the project.
  • Boost version is updated from 1.75.0 to 1.84.0

If need be, add additional information and what the reviewer should look out for in particular:

-/-

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #983
Also: Closes #930 indirectly.

@lenaploetzke lenaploetzke self-assigned this Apr 3, 2024
@lenaploetzke lenaploetzke linked an issue Apr 3, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (8ddb863) to head (db30e10).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         129      129           
  Lines       10056    10072   +16     
=======================================
+ Hits         9688     9704   +16     
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke requested a review from dabele April 10, 2024 07:28
@lenaploetzke lenaploetzke requested a review from mknaranja April 10, 2024 07:28
@lenaploetzke lenaploetzke added the status::in review This issues is in review. label Apr 10, 2024
@lenaploetzke lenaploetzke requested a review from reneSchm April 10, 2024 08:12
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you for sitting through all the failed builds.

Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
@lenaploetzke lenaploetzke requested a review from reneSchm April 11, 2024 06:42
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
@lenaploetzke lenaploetzke requested a review from dabele April 18, 2024 07:58
@dabele dabele merged commit 79158d1 into main Apr 18, 2024
@dabele dabele deleted the 983-bundle-the-boost-git-repo-instead-of-using-the-targz-archiv branch April 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle the boost git repo instead of using the .tar.gz archiv Rebuild boost archive in thirdparty

4 participants