964 Times for Exposed and INS instead of SerialInterval and IncubationTime

[HenrZu]

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

• Removed the Parameters SerialInterval and IncubationTime
• Now, the times for E and INS compartments have to been given directly

If need be, add additional information and what the reviewer should look out for in particular:

• //

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

• Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
• New code adheres to coding guidelines
• No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• Tests are added for new functionality and a local test run was successful (with and without OpenMP)
• Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
• Proper attention to licenses, especially no new third-party software with conflicting license has been added
• (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

• Corresponding issue(s) is/are linked and addressed
• Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
• Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
• No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (afd4982) to head (093d615).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   96.21%   96.21%   -0.01%     
==========================================
  Files         122      122              
  Lines        9667     9638      -29     
==========================================
- Hits         9301     9273      -28     
+ Misses        366      365       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lenaploetzke]

Nice work! Review is not yet finished, the pycode and two test files are missing. Will finish the review soon.

[lenaploetzke]

Finished review. Please link the PR to the existing issue :)

[lenaploetzke]

One more thing: The two parameters SerialInterval and IncubationTime are still used in the file cpp/tests/test_model.cpp. This should be changed.

[HenrZu]

One more thing: The two parameters SerialInterval and IncubationTime are still used in the file cpp/tests/test_model.cpp. This should be changed.

This test is independent from the type of the model. My idea was therefore to let the test exist in the current form to demonstrate that any model can be used here.