Skip to content

950 build cpp msvc debug latest fails at the main branch#951

Merged
lenaploetzke merged 7 commits intomainfrom
950-build-cpp-msvc-debug-latest-fails-at-the-main-branch
Feb 26, 2024
Merged

950 build cpp msvc debug latest fails at the main branch#951
lenaploetzke merged 7 commits intomainfrom
950-build-cpp-msvc-debug-latest-fails-at-the-main-branch

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 23, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #950.

@lenaploetzke lenaploetzke linked an issue Feb 23, 2024 that may be closed by this pull request
2 tasks
@lenaploetzke lenaploetzke self-assigned this Feb 23, 2024
@lenaploetzke lenaploetzke added status::in progress This issue is in progess. prio::critical The priority of this task is very high. This issue is critical for continuation. class::bug Bugs found in the software labels Feb 23, 2024
@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (058b3cc) to head (5e2918a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files         124      124           
  Lines        9699     9699           
=======================================
  Hits         9333     9333           
  Misses        366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. I'd add the relevant version numbers for future reference

Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
@lenaploetzke lenaploetzke merged commit 105816d into main Feb 26, 2024
@lenaploetzke lenaploetzke deleted the 950-build-cpp-msvc-debug-latest-fails-at-the-main-branch branch February 26, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software prio::critical The priority of this task is very high. This issue is critical for continuation. status::in progress This issue is in progess.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build-cpp-msvc (Debug, latest) fails at the main branch

2 participants