936 implement the class infectionstate of the lct model more efficiently#941
Merged
lenaploetzke merged 12 commits intomainfrom Mar 1, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 96.22% 96.21% -0.02%
==========================================
Files 124 122 -2
Lines 9699 9667 -32
==========================================
- Hits 9333 9301 -32
Misses 366 366 ☔ View full report in Codecov by Sentry. |
reneSchm
requested changes
Feb 26, 2024
Member
reneSchm
left a comment
There was a problem hiding this comment.
Great reimplementation of the InfectionState class! There are only a few things that need changing, and optionally some moving/renaming.
…e-lct-model-more-efficiently
2 tasks
reneSchm
requested changes
Feb 29, 2024
Member
reneSchm
left a comment
There was a problem hiding this comment.
The code is mostly good to go, maybe a few comments/names could be improved.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
reneSchm
approved these changes
Mar 1, 2024
Member
reneSchm
left a comment
There was a problem hiding this comment.
All requests resolved, nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #936.