Skip to content

934 Add MEmilio favicon to github pages#935

Merged
mknaranja merged 1 commit intomainfrom
934-add-memilio-favicon-to-webpage
Feb 14, 2024
Merged

934 Add MEmilio favicon to github pages#935
mknaranja merged 1 commit intomainfrom
934-add-memilio-favicon-to-webpage

Conversation

@mknaranja
Copy link
Member

@mknaranja mknaranja commented Feb 14, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

Add MEmilio favicon to github pages

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Close #934

@mknaranja mknaranja linked an issue Feb 14, 2024 that may be closed by this pull request
@mknaranja mknaranja requested a review from HenrZu February 14, 2024 12:42
@codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb2045e) 95.88% compared to head (c41234b) 95.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #935   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         118      118           
  Lines        9400     9400           
=======================================
  Hits         9013     9013           
  Misses        387      387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mknaranja mknaranja merged commit a893257 into main Feb 14, 2024
@mknaranja mknaranja deleted the 934-add-memilio-favicon-to-webpage branch February 14, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MEmilio favicon to webpage

2 participants