917 improve code coverage of ide secir

[lenaploetzke]

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

• Changed one value in the test for parameters.h so that the uncovered lines are now covered.
• Deleted the first check of check_constraints in modelbecause this case already leads to an error in the construction of a model.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

• Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
• New code adheres to coding guidelines
• No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• Tests are added for new functionality and a local test run was successful
• Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
• Proper attention to licenses, especially no new third-party software with conflicting license has been added
• (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

• Corresponding issue(s) is/are linked and addressed
• Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
• Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
• No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #917

[lenaploetzke]

The problem with the uncovered lines 227-230 in parameters.h was that there is a check for negative probabilities (210-214), so that the value -1 already leads to a returned true there.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4cb5ee) 96.22% compared to head (6c42373) 96.26%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   96.22%   96.26%   +0.04%     
==========================================
  Files         124      124              
  Lines        9699     9699              
==========================================
+ Hits         9333     9337       +4     
+ Misses        366      362       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mknaranja]

Merged with #959 .