Skip to content

921 Improve PopulationData Download#922

Merged
patricklnz merged 3 commits intomainfrom
921-improve-population-data-download
Feb 5, 2024
Merged

921 Improve PopulationData Download#922
patricklnz merged 3 commits intomainfrom
921-improve-population-data-download

Conversation

@patricklnz
Copy link
Member

@patricklnz patricklnz commented Feb 5, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • use requests with authentification and deep link from regionalstatistik.de
  • unittest read_data was deleted, since this is not supported for gPd.py

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #921

@patricklnz patricklnz self-assigned this Feb 5, 2024
@patricklnz patricklnz requested a review from reneSchm February 5, 2024 13:19
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@patricklnz patricklnz merged commit 64a8581 into main Feb 5, 2024
@patricklnz patricklnz deleted the 921-improve-population-data-download branch February 5, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Improve download of PopulationData

2 participants