905 add age group resolution to seir and sir model#911
Merged
Conversation
2 tasks
HenrZu
requested changes
Jan 31, 2024
Contributor
HenrZu
left a comment
There was a problem hiding this comment.
Thanks, Good work 👍
We should test all examples and check if the results are still equal to the former version. I would recommend to use the print_table function from the time series class. Then you can simply write the ostream to a txt file and then compare :)
Also, a new example ode_seir_ageres.cpp would probably be nice
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
+ Coverage 96.34% 96.41% +0.06%
==========================================
Files 129 130 +1
Lines 10072 10265 +193
==========================================
+ Hits 9704 9897 +193
Misses 368 368 ☔ View full report in Codecov by Sentry. |
jubicker
reviewed
Apr 18, 2024
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
jubicker
reviewed
Apr 29, 2024
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
jubicker
approved these changes
May 2, 2024
HenrZu
approved these changes
May 2, 2024
reneSchm
pushed a commit
that referenced
this pull request
May 24, 2024
- Integration of age groups into the seir and sir models - New examples using the age groups Co-authored-by: HenrZu <69154294+HenrZu@users.noreply.github.com> Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)