Skip to content

720 config file for data downloads#902

Merged
patricklnz merged 25 commits intomainfrom
720-verbosity-download-option
Feb 5, 2024
Merged

720 config file for data downloads#902
patricklnz merged 25 commits intomainfrom
720-verbosity-download-option

Conversation

@patricklnz
Copy link
Member

@patricklnz patricklnz commented Jan 15, 2024

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • a config file for the data downoads with several options to make the data downloads more user-friendly
    • a verbosity_level can be set
    • a backend for matplotlib can be set to handle some errors when showing plots
    • make_plot and no_raw has been removed from the default arguments of the main functions get_..._data (those can still be set via keyword arguments)
    • also interactivity can be set for a few downloads to handle errors and the progress indicator can be (de-)activated
    • all options can be called from CLI

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #720
Closes #868
Closes #908
Closes #909

@patricklnz patricklnz self-assigned this Jan 15, 2024
@patricklnz patricklnz requested a review from jubicker January 24, 2024 09:35
@patricklnz patricklnz requested a review from jubicker January 31, 2024 08:54
@patricklnz patricklnz merged commit 66693d4 into main Feb 5, 2024
@patricklnz patricklnz deleted the 720-verbosity-download-option branch February 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants