367 responsibility of testing schemes regarding quarantine

[xsaschako]

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

• changed logic from going into quarantine
• few other fixes

Runtime
MAIN:

Benchmark Time CPU Iterations

abm_benchmark/abm_benchmark_50k 7727 ms 7727 ms 1
abm_benchmark/abm_benchmark_100k 13246 ms 13245 ms 1
abm_benchmark/abm_benchmark_200k 28652 ms 28650 ms 1

Branch:

Benchmark Time CPU Iterations

abm_benchmark/abm_benchmark_50k 5350 ms 5350 ms 1
abm_benchmark/abm_benchmark_100k 12251 ms 12247 ms 1
abm_benchmark/abm_benchmark_200k 24540 ms 24533 ms 1

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

• Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
• New code adheres to coding guidelines
• No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• Tests are added for new functionality and a local test run was successful
• Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
• Proper attention to licenses, especially no new third-party software with conflicting license has been added
• (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

• Corresponding issue(s) is/are linked and addressed
• Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
• Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
• No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c18828e) 95.60% compared to head (0c672a1) 95.60%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   95.60%   95.60%   -0.01%     
==========================================
  Files         118      118              
  Lines        9448     9443       -5     
==========================================
- Hits         9033     9028       -5     
  Misses        415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DavidKerkmann]

Thanks for the fixes. Please post a runtime of the code for comparison.