Skip to content

885 Compatibility of specialized simulation and advance functions in Secir and Secirvvs model with flows#889

Merged
mknaranja merged 5 commits intomainfrom
885-compatibility-of-constum-simulation-and-advance-functions-with-flows
Jan 16, 2024
Merged

885 Compatibility of specialized simulation and advance functions in Secir and Secirvvs model with flows#889
mknaranja merged 5 commits intomainfrom
885-compatibility-of-constum-simulation-and-advance-functions-with-flows

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Jan 12, 2024

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • The Secir and SecirVVs Models are overwritting the existing advance functions. Here, we add the support to use these costum advance functions with the FlowSimulation

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

#885

@codecov
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c18828e) 95.60% compared to head (5504ea1) 95.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #889   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         118      118           
  Lines        9448     9448           
=======================================
  Hits         9033     9033           
  Misses        415      415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBetzDLR MaxBetzDLR requested a review from reneSchm January 15, 2024 15:17
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please review the documentation:
Almost all doc strings are missing @brief and @return, as well as [in] and [out} notes on the params.

@HenrZu HenrZu changed the title 885 Compatibility of costum simulation and advance functions with flows 885 Compatibility of specialized simulation and advance functions in Secir and Secirvvs model with flows Jan 16, 2024
@mknaranja mknaranja merged commit cdc62ee into main Jan 16, 2024
@mknaranja mknaranja deleted the 885-compatibility-of-constum-simulation-and-advance-functions-with-flows branch January 16, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specialized simulation advance functions are missing in FlowSimulation and Bindings.

3 participants