Skip to content

680 implement lct model#771

Closed
lenaploetzke wants to merge 65 commits intomainfrom
680-implement-lct-model
Closed

680 implement lct model#771
lenaploetzke wants to merge 65 commits intomainfrom
680-implement-lct-model

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Sep 16, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • added additional model based on the Linear Chain Trick.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #680

@mknaranja mknaranja requested a review from dabele November 29, 2023 11:49
@mknaranja
Copy link
Member

@dabele I would like to merge this for the functionality first (except for small adaptations that go in the right direction maybe) and then create a new issue to adapt/generalize the new model to our compartmental or flow model base classes. I think this needs then also adaptations of the ODE models. Maybe you could have a look and write down what your redesign suggestions are?

@lenaploetzke lenaploetzke added status::on hold This issue is on hold. and removed status::in progress This issue is in progess. prio::high The priority of this task is high. labels Feb 5, 2024
@lenaploetzke
Copy link
Member Author

@lenaploetzke lenaploetzke deleted the 680-implement-lct-model branch May 17, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::feature A feature to be implemented for some part of the software loc::infrastructure General MEmilio Infrastructure related issues status::on hold This issue is on hold.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement LCT model

2 participants