636 make python serialization usable again#761
Merged
Conversation
added 10 commits
May 11, 2023 17:27
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 130 130
Lines 10364 10364
=======================================
Hits 9994 9994
Misses 370 370 ☔ View full report in Codecov by Sentry. |
dabele
requested changes
Oct 6, 2023
Member
dabele
left a comment
There was a problem hiding this comment.
I like the general design, but have a few concerns about the implementation. I also don't understand some of the choices of TryPickling/ForcePickling/NoPickling, but I only added comments for some cases. Maybe try to explain your general reasoning there.
dabele
requested changes
Dec 12, 2023
pycode/memilio-simulation/memilio/simulation/utils/parameter_set.h
Outdated
Show resolved
Hide resolved
pycode/memilio-simulation/memilio/simulation/compartments/compartmentalmodel.h
Outdated
Show resolved
Hide resolved
added 8 commits
April 29, 2024 10:34
dabele
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes made, additional Information and what the Reviewer should look out for:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #636