Skip to content

271 expand tests of the python bindings#605

Merged
HenrZu merged 26 commits intomainfrom
271-expand-tests-of-the-python-bindings
Feb 6, 2024
Merged

271 expand tests of the python bindings#605
HenrZu merged 26 commits intomainfrom
271-expand-tests-of-the-python-bindings

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Mar 30, 2023

Changes

Update tests of ODE Seir and Secir model to include a validation of the python bindings by comparing them to results from a c++ simulation. Also change the corresponding examples to use the same parameters.

Merge Request - GuideLine Checklist

  • Check our git workflow before opening a Pull request/Merge request.
  • Request a reviewer when your work is ready to review, before this please use the draft feature.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Additional context

Please list additional information or things a reviewer should look out for.

Closes #271

@MaxBetzDLR MaxBetzDLR linked an issue Mar 30, 2023 that may be closed by this pull request
@MaxBetzDLR MaxBetzDLR self-assigned this Mar 30, 2023
@MaxBetzDLR MaxBetzDLR added the loc::python interface This issue concerns the python interface to the backend implementation. label Mar 30, 2023
@MaxBetzDLR MaxBetzDLR marked this pull request as ready for review March 30, 2023 08:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f16ed4) 95.60% compared to head (270e5a5) 95.88%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   95.60%   95.88%   +0.27%     
==========================================
  Files         118      118              
  Lines        9443     9397      -46     
==========================================
- Hits         9028     9010      -18     
+ Misses        415      387      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBetzDLR MaxBetzDLR marked this pull request as draft May 11, 2023 15:07
@MaxBetzDLR MaxBetzDLR marked this pull request as ready for review January 11, 2024 13:55
@MaxBetzDLR MaxBetzDLR requested a review from HenrZu January 11, 2024 14:22
MaxBetzDLR and others added 2 commits January 25, 2024 13:51
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
@MaxBetzDLR MaxBetzDLR requested a review from HenrZu January 30, 2024 13:09
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
@HenrZu HenrZu mentioned this pull request Feb 6, 2024
11 tasks
@HenrZu HenrZu merged commit d6bb6fd into main Feb 6, 2024
@HenrZu HenrZu deleted the 271-expand-tests-of-the-python-bindings branch February 6, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loc::python interface This issue concerns the python interface to the backend implementation.

Projects

Development

Successfully merging this pull request may close these issues.

Expand tests of the python bindings

3 participants