364 create abm simulation with percentiles output#572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 95.01% 95.25% +0.24%
==========================================
Files 112 113 +1
Lines 8800 9103 +303
==========================================
+ Hits 8361 8671 +310
+ Misses 439 432 -7
☔ View full report in Codecov by Sentry. |
…tion-with-percentiles-output
… issue with Python code
DavidKerkmann
left a comment
There was a problem hiding this comment.
Not a complete review, just some quick comments about important parts.
xsaschako
left a comment
There was a problem hiding this comment.
I just looked breifly into it.
I understand we need to be more flexible in regards to age groups but we shouldn't hardcode specific things.
After a discussion with martin we maybe should have something like an object where you can define specific age groups. This object would help to identify age groups for certain rules, e.g. who goes to school etc..
We can discuss this next week (i'm not there on tuesday), or feel free to contact me :-)
DavidKerkmann
left a comment
There was a problem hiding this comment.
Thank you @khoanguyen-dev for the amount of work and all the changes!
In particular, a lot of improvements have been made that go beyond what was intended for this issue.
I have finally complete the full review with some requests and open discussion points.
These include some small comments for the tests and the copy operations and some medium sized changes for the percentile computations/parameter ensemble. Please wait with working on the points that mention a discussion before we have decided how to proceed.
DavidKerkmann
left a comment
There was a problem hiding this comment.
Thanks for the quick changes! I have a couple of follow-up questions and some more change requests for the analyze_result. Feel free to contact me if you have any questions.
|
Great commitment @DavidKerkmann and @khoanguyen-dev. I get this bunch of notifications about change requests and changes, it is a pity that I do not find the time but you are doing great work! Just to leave this note :) |
…semble_params_percentile()
DavidKerkmann
left a comment
There was a problem hiding this comment.
All questions have been resolved or have been addressed in another issue.
changes have been made and corrected, no time for re-review
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
The following questions are addressed in the documentation if need be:
Developers (what did you do?, how can it be maintained?)
For users (how to use your work?)
For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!
Checks by code reviewer(s):
Closes #364