326 add extensive testing scheme to abm modell

[DavidKerkmann]

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

• There is at least one issue associated with the pull request.
• The branch follows the naming conventions as defined in the git workflow.
• New code adheres with the coding guidelines
• Tests for new functionality has been added
• A local test was succesful
• There is appropriate documentation of your work. (use doxygen style comments)
• If new third party software is used, did you pay attention to its license? Please remember to add it to the wiki after successful merging.
• If new mathematical methods or epidemiological terms are used, has the glossary been updated ? Did you provide further documentation ?
  is present or referenced. Please provide your references.
• The following questions are addressed in the documentation*: Developers (what did you do?, how can it be maintained?), For users (how to use your work?), For admins (how to install and configure your work?)
• For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

• Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
• The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
• There are appropriate unit tests and they pass.
• The git history is clean and linearized for the merge request.
• Coverage report for new code is acceptable.

closes #326, closes #368

[DavidKerkmann]

Since we both implemented certain parts of the test, we need to decide on one implementation and remove the other one (TestingScheme & TestingRule vs. TestingSet).

[mknaranja]

@DavidKerkmann @xsaschako Could you please ensure that the code coverage runs? I think there are still untested lines and it would be good to have the coverage. It needs test-py-epidata. Maybe you need to merge the current main for that?

[mknaranja]

I really like the new implementation, thanks a lot @DavidKerkmann and @xsaschako. There is only one major issue: To my understanding there is always only one TestingScheme at a time (see certain comments). Currently there is no error handling for overlapping schemes etc

Maybe a better solution for std::vector testing_schemes could be given by our dampings implementation, i.e, a vector of pairs which a formed by a scheme and a start day. The scheme that has the highest start_day < t (with t the current time) is then always active.

Certain minor issues also given in the comments.

[xsaschako]

Major issue with one object managing the testing schemes got added.
There are some tests missing

[mknaranja]

In https://github.com/DLR-SC/memilio/blob/326-add-extensive-testing-scheme-to-abm-modell/cpp/models/abm/location.h#L189 we have

LocalInfectionParameters m_parameters;

Do we need this as well as their getters anymore?

Missing unit test review.

[mknaranja]

only one comment/question

[mknaranja]

@DavidKerkmann What s the status? :)

[DavidKerkmann]

Closes #368 with the last change to run_strategy.

[DavidKerkmann]

@DavidKerkmann What s the status? :)

Should be good to go. Only a download test fails, which we didn't touch.

[mknaranja]

Two minor changes required or to be denied with a reason, then we can finally merge it :)