1110 Migrate Python packages to use pyproject.toml for builds#1409
Merged
1110 Migrate Python packages to use pyproject.toml for builds#1409
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
+ Coverage 97.27% 97.30% +0.02%
==========================================
Files 184 187 +3
Lines 15802 16024 +222
==========================================
+ Hits 15372 15592 +220
- Misses 430 432 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
reneSchm
requested changes
Nov 26, 2025
Member
reneSchm
left a comment
There was a problem hiding this comment.
Thanks for putting in all that work!
The tomls look like they've got everything, I do have some questions on the CI and CMake, though.
Documentation also looks ok.
reneSchm
reviewed
Nov 27, 2025
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
reneSchm
reviewed
Dec 1, 2025
reneSchm
reviewed
Dec 1, 2025
Contributor
Author
|
Moving the tests out of the installed package and switching the order of the install options (editable or not) is moved into #1440 |
12 tasks
reneSchm
approved these changes
Dec 3, 2025
jubicker
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
setup.pywith PEP 621pyproject.tomlacross all Python subpackagesIf need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)