1365 Potential use of wrong dt_max in ControlledStepperWrapper

[reneSchm]

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

• Changed how dt_max of the wrapped stepper is set, so it always uses the same value as IntegratorCore::get_dt_max().
• Change the step method so that it computes its result in place, avoiding two copies.

If need be, add additional information and what the reviewer should look out for in particular:

• Tested the change to the ControlledStepperWrapper with the integrator_step_benchmark, with vector sizes from 8 to 100. No significant changes compared to the prior version.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

• Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
• New code adheres to coding guidelines
• No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• Tests are added for new functionality and a local test run was successful (with and without OpenMP)
• Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
• Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
• Proper attention to licenses, especially no new third-party software with conflicting license has been added
• (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

• Corresponding issue(s) is/are linked and addressed
• Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
• Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
• No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (75ce311) to head (48c1fad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
+ Coverage   97.24%   97.25%   +0.01%     
==========================================
  Files         173      173              
  Lines       15204    15203       -1     
==========================================
+ Hits        14785    14786       +1     
+ Misses        419      417       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[MaxBetzDLR]

Some questions about the used boost stepper

[MaxBetzDLR]

All comments resolved

[MaxBetzDLR]

Merge looks good!