Skip to content

1315 support IO functionality with single age group for ODE SECIR#1354

Merged
HenrZu merged 10 commits intomainfrom
1315-io-with-single-age-group-v2
Aug 28, 2025
Merged

1315 support IO functionality with single age group for ODE SECIR#1354
HenrZu merged 10 commits intomainfrom
1315-io-with-single-age-group-v2

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Aug 18, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • when inititialize the ODE SECIR model with real data, we were restricted to a model with 6 age groups (using the official reported data)
  • Now, we can also input a model with a single age group with correct initialization.
  • Short Fix for readthedocs build.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu changed the title 1315 IO functionality with single age group for ODE SECIR 1315 support IO functionality with single age group for ODE SECIR Aug 18, 2025
@HenrZu HenrZu linked an issue Aug 18, 2025 that may be closed by this pull request
5 tasks
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.26%. Comparing base (e12b5a1) to head (a3cc1dd).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cpp/models/ode_secir/parameters_io.h 97.82% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   97.34%   97.26%   -0.09%     
==========================================
  Files         174      174              
  Lines       15098    15153      +55     
==========================================
+ Hits        14697    14738      +41     
- Misses        401      415      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu requested a review from charlie0614 August 19, 2025 09:01
Copy link
Member

@charlie0614 charlie0614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See the minor questions.

HenrZu and others added 3 commits August 22, 2025 09:12
Co-authored-by: Carlotta Gerstein <100771374+charlie0614@users.noreply.github.com>
@HenrZu HenrZu mentioned this pull request Aug 22, 2025
5 tasks
@HenrZu HenrZu requested a review from charlie0614 August 22, 2025 08:53
@HenrZu HenrZu merged commit f0abb25 into main Aug 28, 2025
57 checks passed
@HenrZu HenrZu deleted the 1315-io-with-single-age-group-v2 branch August 28, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support IO with single age groups

2 participants