1342 make geographic location available to all of MEmilio#1346
Merged
kilianvolmer merged 46 commits intomainfrom Oct 29, 2025
Merged
1342 make geographic location available to all of MEmilio#1346kilianvolmer merged 46 commits intomainfrom
kilianvolmer merged 46 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
========================================
Coverage 97.26% 97.27%
========================================
Files 176 180 +4
Lines 15439 15642 +203
========================================
+ Hits 15017 15215 +198
- Misses 422 427 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mknaranja
reviewed
Aug 25, 2025
mknaranja
reviewed
Aug 25, 2025
charlie0614
requested changes
Aug 25, 2025
Co-authored-by: Carlotta Gerstein <100771374+charlie0614@users.noreply.github.com> Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
charlie0614
requested changes
Sep 10, 2025
charlie0614
reviewed
Sep 10, 2025
HenrZu
requested changes
Oct 10, 2025
Co-authored-by: HenrZu <69154294+HenrZu@users.noreply.github.com>
reneSchm
requested changes
Oct 14, 2025
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
…o' of github.com:SciCompMod/memilio into 1342-Make-GeographicLocation-available-to-all-of-MEmilio
reneSchm
reviewed
Oct 16, 2025
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
…o' of github.com:SciCompMod/memilio into 1342-Make-GeographicLocation-available-to-all-of-MEmilio
reneSchm
reviewed
Oct 29, 2025
Member
reneSchm
left a comment
There was a problem hiding this comment.
I scrolled over all changes again, I think the code looks good. Maybe check your documentation again, I found a missing and floating docstring, but when that is done, I say this is ready for merging.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
reneSchm
approved these changes
Oct 29, 2025
HenrZu
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
GeographicLocationtomemilio/geography/locations.hGeographicLocations on the sphereGeographicLocationIf need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1342